Skip to content

Switch back to charlock_holmes gem

Stan Hu requested to merge sh-switch-charlock-holmes into master

What does this MR do and why?

The changes for static_holmes were upstreamed to charlock_holmes v0.7.9, (https://github.com/brianmario/charlock_holmes/releases/tag/v0.7.9), so we can switch back to the gem now.

How to set up and validate locally

  1. Run bundle install in this branch.
  2. Run bundle exec irb and run a test:
require 'charlock_holmes'
CharlockHolmes::Converter.convert("test-me", "UTF-8", "UTF-16")
=> "\xFF\xFE\x74\x00\x65\x00\x73\x00\x74\x00\x2D\x00\x6D\x00\x65\x00"
Edited by Stan Hu

Merge request reports