Use ServiceResponse for VerifyPagesDomainService
requested to merge gitlab-community/gitlab:467235-gerardo-navarro-refactor-use-service-response-in-verify-pages-domain-service into master
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
- Applying recommendation to return ServiceResponse for service classes,see https://docs.gitlab.com/ee/development/reusing_abstractions.html#serviceresponse.
Changelog: other
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Only changes in the backend.
How to set up and validate locally
- Run the related tests
bundle exec rspec spec/services/verify_pages_domain_service_spec.rb ee/spec/services/ee/verify_pages_domain_service_spec.rbRelated to #467235
Edited by Gerardo Navarro