Add multi steps numbers
What does this MR do and why?
In the code flow viewer
we are shown the step number.
In this phase we are using the 'row' location without 'column' location.
When there are a few steps in the same row (but in a different columns), in the UI it's looks like a bug.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Screen_Recording_2024-08-08_at_20.25.11 |
How to set up and validate locally
- Upload a GitLab Ultimate license
- Enable the feature flag (
echo "Feature.enable(:vulnerability_code_flow)" | rails c
) - Clone the code flow project and run his pipeline to display vulnerabilities
- Navigate to the project => Secure => Vulnerability report => Select the first vulnerability to navigate to the vulnerability details page
- Apply the following patch to show the new features
Patch
diff --git a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability.vue b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability.vue
index ca4110274476..319e8f7180ae 100644
--- a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability.vue
+++ b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability.vue
@@ -56,6 +56,7 @@ export default {
},
},
showCodeFlowTabs() {
+ return true
return (
this.glFeatures.vulnerabilityCodeFlow && !isEmpty(this.vulnerability.details.codeFlows)
);
diff --git a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_details.vue b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_details.vue
index bfbc47e4c041..72fd47398163 100644
--- a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_details.vue
+++ b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_details.vue
@@ -221,6 +221,7 @@ export default {
return this.vulnerability.location?.file && this.vulnerability.location?.startLine;
},
showCodeFlowButton() {
+ return true
return (
this.glFeatures.vulnerabilityCodeFlow && !isEmpty(this.vulnerability.details.codeFlows)
);
- Make sure the steps are displayed as needed in the code flow viewer - the step number, line number and content are highlighted.
Numbered steps to set up and validate the change are strongly suggested.
Related to #477336 (closed)
Edited by Chen Charnolevsky