Skip to content

Not using instance variables when pushing FE FF

Max Fan requested to merge rca_push_ability_not_instance_variables into master

What does this MR do and why?

Currently on SM, the /troubleshoot button sometimes disappears upon refresh for a job page.

There is no permission issue as I've verified in the console that the user does have permission for that job.

This MR tries to fix that by not using the instance variable in case there's a race condition.

Note: I cannot reproduce this on Saas / staging

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Screen Recording 2024-08-08 at 1.28.39 PM.mov

How to set up and validate locally

Hard to replicate locally, I guess just make sure this doesn't break anything?

Edited by Max Fan

Merge request reports

Loading