Add Flow to wait for pipeline via API
What does this MR do and why?
In this MR:
- I'm adding a new
Flow::Pipeline
to wait for pipeline to be created via API first before we visit the Pipelines page to check on/interact with latest pipeline via the UI. - The hope is to slowly refactor all tests that needs to wait/refresh Pipelines page for first pipeline to show up to instead wait for pipeline to be created via API first then perform actions in the UI afterwards. After that, I'm hoping to refactor
visit_latest_pipeline
using the API as well, something likeproject.lastest_pipeline.visit!
and perhaps similar idea for visiting Job's Details page, these ideas should help reduce the number of button clicking actions per test. - Trying out with a few specs under
features/browser_ui/5_package
. - And since I applied the new flow in these specs, I also refactored them a bit: addressed rubocop complains, remove unnecessary api removals, remove unnecessary wait when committing files to project.
Related gitlab-org/quality/quality-engineering/team-tasks#2954
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Tiffany Rea