Skip to content

Draft: Call `make make_necessary_dirs` instead

Ash McKenzie requested to merge ashmckenzie/gitlab-shell-bin-install-rename into master

What does this MR do and why?

⚠ Add 'make make_necessary_dirs' alias (gitlab-shell!1119 - merged) needs to be merged first.

⚠ Bump GitLab Shell to 14.39.0 (!162661 - merged) needs to be merged first.

This MR updates a few places where bin/install is called as part of setting up gitlab-shell and instead, calls make make_necessary_dirs which performs the same logic, but with a more suitable name.

This MR will assist /bin/check is a very generic binary name (gitlab-shell#603 - closed).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ash McKenzie

Merge request reports