Skip to content

Rewrite system note CSS

Annabel Dunstone Gray requested to merge system-notes-css into master

What does this MR do and why?

(see more details in #469616 (closed))

For system notes only:

  • Use utility classes
  • Create notes/system_notes_v2.scss for all notes-related CSS (which will be renamed after everything has been updated/removed)
  • Update existing unique classes

What does this MR not do?

The following will be done separately:

  • Any other note types
  • work item system notes

Note The UI/screenshots are slightly different. In some cases the alignment has been improved (changed description), in others it's slightly of (system notes within diffs). In an effort to not nest styles too much I'd prefer to rely on the utility classes until we're further along in this effort.

Screenshots or screen recordings

Before After
Screenshot_2024-08-14_at_2.58.20_PM Screenshot_2024-08-14_at_2.55.44_PM
Screenshot_2024-08-14_at_2.59.27_PM Screenshot_2024-08-14_at_2.56.20_PM
Screenshot_2024-08-14_at_2.59.44_PM Screenshot_2024-08-14_at_2.56.40_PM
Screenshot_2024-08-14_at_3.00.25_PM Screenshot_2024-08-14_at_2.57.27_PM

How to set up and validate locally

Look at places that have have system notes in the activity feed (merge requests, issues, epics, etc)

Links

Edited by Annabel Dunstone Gray

Merge request reports