Skip to content

Workhorse: fix unix socket path too long

Mikhail Mazurskiy requested to merge ash2k/fix-long-path-unix-socket into master

What does this MR do and why?

Workhorse: fix unix socket path too long

This fixes errors like this:

listen unix /var/folders/xx/xx/T/xx/001/gitaly.sock: bind: invalid argument

I used the approach from Gitaly: https://gitlab.com/gitlab-org/gitaly/-/blob/42363783b78378fc25d81204fe85ee28b37fc32c/internal/testhelper/configure.go#L170-195. It was added in testhelper: Clean up temporary files (gitaly!3994 - merged). Also Fix UNIX socket file too long (gitaly!3612 - merged).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Run tests on macOS. It didn't work for me, now it does.

Edited by Mikhail Mazurskiy

Merge request reports