Skip to content

Fix timeout when checking group dependencies (17.3 backport)

Brian Williams requested to merge bwill/fix-dependency-list-exists-timeout-17-3 into 17-3-stable-ee

What does this MR do and why?

This MR is the 17.3 backport for !162857 (merged)

In !161215 (merged) we migrated the dependency list empty state to use a new database query. This query checks a column which is only covered by partial indexes with a WHERE archived = false clause. We forgot to include this scope on the new query which causes it to have no index coverage so it attempts to scan the entire table and times out. We only show dependencies from unarchived projects on the depenency list so the correct behavior is to only check for existence of unarchived dependencies. This fixes the timeout as the query can now utilize partial indices.

Fixes: #479300 (closed)

Before query: https://console.postgres.ai/gitlab/gitlab-production-main/sessions/30803/commands/95639

After query: https://console.postgres.ai/gitlab/gitlab-production-main/sessions/30803/commands/95640

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Vasilii Iakliushin

Merge request reports