Skip to content

Switch to max-params rule from eslint plugin

Lorenz van Herwaarden requested to merge eslint/remove-max-params-gitlab into master

What does this MR do and why?

With Update dependency @gitlab/eslint-plugin to v20 (!162651 - merged) • GitLab Dependency Bot • 17.4 merged, we can remove the max-params rule set in gitlab-org/gitlab's eslint config in favor of it coming from @gitlab/eslint-plugin itself.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

You can add a 4th parameter to any JS function and validate that eslint will still complain.

Edited by Lorenz van Herwaarden

Merge request reports