Skip to content

Temporary unapprove approval rules on MR create

Marc Shaw requested to merge 467953-ability-to-merge-the-mr-even-if-we-have-approval-rules-2 into master

What does this MR do and why?

On MR Create, we sync some of the approval rules, therefore we should temporarily unapprove the MR so that it has time to sync.

In a follow up MR, we are going to introduce a new 'syncing' state to the mergeability framework to express the current state of certain checks.

To Test:

  • Add a sleep to line 14 in (ee/app/services/merge_requests/sync_code_owner_approval_rules.rb) sleep(10)
  • Create a project which only requires a codeowner approval to merge *md @colette
  • Create an MR, and you will be able to merge straight away
  • Turn on FF Feature.enable(:temp_unapprove_mr_create)
  • Create another MR, and you will not be able to merge straight away

Related to #467953

Edited by Marc Shaw

Merge request reports