Skip to content

Ensure discussion reply for linked comments has correct top padding

What does this MR do and why?

The discussion reply box for work items was built without the class .public-note applied to it, but that class name was functionally necessarty to get the top padding necessary to separate the reply from a linked comment. The style rule can be safely edited to remove this class.

Changelog: fixed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Type Before After
Work item linked comment (fixed) image image
Work item internal comment (unchanged) image image
Issuable linked comment (unchanged) image image
Issuable internal comment (unchanged) image image
MR linked comment (unchanged) image image
MR internal comment (unchanged) image image

How to set up and validate locally

  1. Check out this branch
  2. Visit a work item in the GDK
  3. Add a comment
  4. Copy the link to the comment and open it in a new tab
  5. Click the reply button on the target comment
  6. You will see that there is an appropriate gap at the top of the comment input.
  7. Reply to the comment
  8. Copy the link to your reply
  9. open that url in a new tab
  10. You will see that there is an appropriate gap between the blue highlighted target comment and the new reply box.

Related to #479201 (closed), #469616 (closed)

Edited by Chad Lavimoniere

Merge request reports

Loading