Skip to content

Background Migration: rm PopulateVulnerabilityDismissalFields spec

Michael Becker requested to merge 462336-test-spec-lib-gitlab-background_migration-populate_vulnerability_dismissal_fields_spec-rb into master

What does this MR do and why?

This spec was added to test a background migration in April 2023. The migration has long been completed on .com

The test is very slow, as many background migration specs are. It is sort of inherent to the nature of the task. In other words, a batched background migration is used when we need to do costly database manipulations, and to test those situations requires costly test setup.

So, until the migration is complete, it makes sense to have these specs.

There can be a pretty significant lag from when a batched background migration is finalized until it is actually removed from the codebase. For example, the migration related to this spec is still in the process of being removed.1

After the migration is complete, I think the cost of carrying these specs around (slow pipelines, failing pipelines due to timeouts) outweigh the risk of someone modifying a batched background migration that is pending deletion.

resolves: #462336
Changelog: removed

  1. 17c45e8f ↩

Edited by Michael Becker

Merge request reports