Skip to content

Refactor draft notes CSS

Annabel Dunstone Gray requested to merge draft-notes-css into master

What does this MR do and why?

  • Renames draft_note.scss --> draft_note_v2.scss (which will be reverted after all the comments/notes have bene refactored)
  • Moves draft styles into file
  • Removes styles from notes.scss
  • Use utility classes when possible

Follow up to Rewrite system note CSS (!162639 - merged) and Use new CSS file for work items system notes (!163663 - merged)

(see more details in #469616 (closed))

Note The UI/screenshots are slightly different. In some cases the alignment has been improved (changed description), in others it's slightly of (system notes within diffs). In an effort to not nest styles too much I'd prefer to rely on the utility classes until we're further along in this effort.

Screenshots or screen recordings

Overview tab

Before After
Screenshot_2024-08-23_at_2.11.51_PM Screenshot_2024-08-23_at_2.11.08_PM
Screenshot_2024-08-23_at_2.17.37_PM Screenshot_2024-08-23_at_2.16.57_PM

Changes tab

Before After
Screenshot_2024-08-23_at_2.12.20_PM Screenshot_2024-08-23_at_2.10.51_PM
Screenshot_2024-08-23_at_2.17.24_PM Screenshot_2024-08-23_at_2.17.07_PM

How to set up and validate locally

  • Create pending comments on MR, check both overview and changes tabs

Links

Edited by Annabel Dunstone Gray

Merge request reports