Skip to content

Edit deploy keys of a protected branch in a drawer

Paulina Sedlak-Jakubowska requested to merge 474084-search-for-deploy-keys into master

What does this MR do and why?

  • adds a list selector for deploy keys inside the Allowed to push and merge drawer
  • allows editing of deploy keys in Allowed to push and merge branch protection
  • unifies deploy_key_item.vue component with other item components in that directory

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-09-02_at_13.05.50 Screen_Recording_2024-09-02_at_13.04.37

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In rails console enable the experiment fully

    Feature.enable(:edit_branch_rules)

  2. Make sure you have a deploy key with read-write permission for that project: https://docs.gitlab.com/ee/user/project/deploy_keys/#create-a-project-deploy-key

  3. Go to Project / Settings / Repository / Protected branches and set the deploy key in Allowed to push and merge dropdown.

  4. Scroll up to Project / Settings / Repository / Branch rules and click View details for a branch you protected with the key

  5. When on Branch rule details page, make sure you can see your deploy key in the Allowed to push and merge section

  6. In Allowed to push and merge section click Edit and change any settings

  7. Search for a key, select one from dropdown and save the drawer.

  8. In Allowed to push and merge section click Edit and change any settings

  9. Delete the key you chose before and save the drawer.

Related to #474084 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports