Skip to content

Update close button on secure spec configuration_form.rb

Will Meek requested to merge secure_spec_close_update into master

What does this MR do and why?

There was an update to gitlab-UI gitlab-ui!4505 (merged) which changed the close button to close-xs-button.

The Secret Push Protection toggle uses this, which caused a failure - https://gitlab.com/gitlab-org/gitlab/-/issues/480816

This MR updates it.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

GITLAB_QA_USER_AGENT =<USER_AGENT> GITLAB_ADMIN_USERNAME=<ADMIN_USERNAME> GITLAB_ADMIN_PASSWORD="<ADMIN_PASSWORD>" GITLAB_USERNAME=<USERNAME> GITLAB_QA_ACCESS_TOKEN="<ACCESS_TOKEN>" GITLAB_PASSWORD="<GITLAB_PASSWORD>"  QA_DEBUG=true WEBDRIVER_HEADLESS=true bundle exec bin/qa Test::Instance::All https://staging.gitlab.com qa/specs/features/ee/browser_ui/13_secure/secret_push_protection_spec.rb
Edited by Will Meek

Merge request reports

Loading