Skip to content

Fix FactoriesInMigrationSpecs flagging sends with no arguments

Brian Williams requested to merge bwill/fix-factories-in-migration-spec into master

What does this MR do and why?

Fix FactoriesInMigrationSpecs flagging sends with no arguments

... matches on zero arguments which causes it to flag things like build.id. _ matches on at least one argument, so it should only flag things like build(:model).

Relates to: !164110 (comment 2077921265)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Brian Williams

Merge request reports