Skip to content

Make metrics list search bar always visible

Daniele Rossetti requested to merge drosse/fix-metrics-list-layout into master

What does this MR do and why?

Change the metrics list layout so that the search bar is always visible. Before this change, the search bar was replaced by a loading icon while search was in flight.

This change makes the layout consistent with logs and traces, and as a bonus , it fixes/woraround a filtered search bug that was breaking the layout ( Big gap in search/filter bar when unmounting an... (#456355))

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-08-28_at_10.26.31 Screen Recording 2024-08-28 at 10.25.02.mov

How to set up and validate locally

  1. You need a GitLab Ultimate license.
  2. Enable the :observability_features feature flag.
  3. Apply patch to load local mocks git apply < <(curl -s https://gitlab.com/-/snippets/3725609/raw/main/mock.patch)
  4. Go to http://gdk.test:3443/flightjs/Flight/-/metrics
Edited by Daniele Rossetti

Merge request reports