Skip to content

Stop using kilobyte conversion for max highlight file size

James Fargher requested to merge fix_broken_master_highlight_size_config into master

What does this MR do and why?

Fixes gitlab-org/quality/engineering-productivity/master-broken-incidents#8153 (closed)

Using kilobyte actually converts it to the number of bytes in a kilobyte and this setting should be the number of kilobytes not the number of bytes.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Run these two specs together:

bundle exec rspec ee/spec/initializers/1_settings_spec.rb ee/spec/services/ee/merge_requests/after_create_service_spec.rb

Merge request reports