Adding more wait and retry on pipeline waits
What does this MR do and why?
Related https://gitlab.com/gitlab-org/gitlab/-/issues/481612, https://gitlab.com/gitlab-org/gitlab/-/issues/481613, https://gitlab.com/gitlab-org/gitlab/-/issues/481643, https://gitlab.com/gitlab-org/gitlab/-/issues/481642
See explanation https://gitlab.com/gitlab-org/gitlab/-/issues/481642#note_2081214771
I think these specs can do without making sure the latest pipeline has started. They can visit the job page as soon as the pipeline is created and wait for the job to start and run there. Adding project.visit!
step instead so that the screenshot isn't on the general group page if test does fail.
I also increased wait time in wait_for_latest_pipeline_to_start because I checked a couple of projects from failed job and they all had successful pipelines eventually. So we just need to wait a tat longer. Example failed job https://ops.gitlab.net/gitlab-org/quality/staging-canary/-/jobs/15177052 . Failed waiting for pipeline to run
[Aug 29 2024 16:58:41 UTC (QA Tests)] INFO -- Waiting for composer-package-project-799b8ec430e464df's latest pipeline to be created...
[Aug 29 2024 16:58:41 UTC (QA Tests)] INFO -- Waiting for composer-package-project-799b8ec430e464df's latest pipeline to start...
[Aug 29 2024 16:58:41 UTC (QA Tests)] INFO -- Waiting for composer-package-project-799b8ec430e464df's latest pipeline to have status running...
[Aug 29 2024 16:59:42 UTC (QA Tests)] INFO -- Removed a QA::Resource::ProjectRunner with name 'qa-runner-1724950664'
[Aug 29 2024 16:59:42 UTC (QA Tests)] INFO -- Executing: `docker rm -f qa-runner-1724950664`
[Aug 29 2024 16:59:43 UTC (QA Tests)] INFO -- Saving screenshot..
publishes a composer package and deletes it (FAILED - 1)
But pipeline did run and succeeded https://staging.gitlab.com/gitlab-qa-sandbox-group-5/qa-test-2024-08-29-16-57-44-799227b959ff3e22/composer-package-project-799b8ec430e464df/-/pipelines/23121424
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #481642