Skip to content

Ensure deploy key variables exist before query

Andrew Fontaine requested to merge afontaine/deploy-key-vue-3 into master

What does this MR do and why?

These are initialized to default values, but to ensure things are performed in the right order, we need to skip querying the deploy keys until the query for the current page and scope complete.

This fixes the Vue 3 version of the test.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  1. Run yarn jest deploy_keys/components/app
  2. Run VUE_VERSION=3 yarn jest deploy_keys/components/app
  3. See no failures!
  4. Also go to a project, go to Settings > Repository and expand the Deploy keys section to ensure they still load 👍

Merge request reports