Skip to content

Resolve "Ensure specs in spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js pass in Vue3"

Vanessa Otto requested to merge 480301-ensure-specs-in-spec-frontend-vue_shared-components-number_to_human_size into master

What does this MR do and why?

Close #480301 (closed) #480322 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-09-02_at_10.39.38 Screenshot_2024-09-02_at_10.47.20
Screenshot_2024-09-02_at_10.48.54 Screenshot_2024-09-02_at_10.48.27

How to set up and validate locally

  1. For number_to_human_size, start Storybook with yarn storybook:start
  2. Go to the story
  3. For time_tracker, go to any MR page, e.g. Flight MR 4
  4. Enter a time tracking estimate
  5. Save

Vue 2 specs:

yarn jest spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js  spec/frontend/sidebar/components/time_tracking/time_tracker_spec.js

Vue 3 specs:

VUE_VERSION=3 yarn jest spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js  spec/frontend/sidebar/components/time_tracking/time_tracker_spec.js

Related to #480301 (closed)

Edited by Vanessa Otto

Merge request reports