Resolve "Ensure specs in spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js pass in Vue3"
requested to merge 480301-ensure-specs-in-spec-frontend-vue_shared-components-number_to_human_size into master
What does this MR do and why?
Close #480301 (closed) #480322 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- For
number_to_human_size
, start Storybook withyarn storybook:start
- Go to the story
- For
time_tracker
, go to any MR page, e.g. Flight MR 4 - Enter a time tracking estimate
- Save
Vue 2 specs:
yarn jest spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js spec/frontend/sidebar/components/time_tracking/time_tracker_spec.js
Vue 3 specs:
VUE_VERSION=3 yarn jest spec/frontend/vue_shared/components/number_to_human_size/number_to_human_size_spec.js spec/frontend/sidebar/components/time_tracking/time_tracker_spec.js
Related to #480301 (closed)
Edited by Vanessa Otto