Skip to content

Light Theme is not rendering correctly

Tomas Bulva requested to merge 481985-zoekt-search-multiple-matches-ui-followup into master

What does this MR do and why?

This Mr is fixing a couple of theme related rendering bugs.

  • Highlighting of the search term in the file name
  • Divider lines between chunks

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Light theme:

Before After
Screenshot_2024-09-08_at_19.12.29 Screenshot_2024-09-08_at_18.30.58
Screenshot_2024-09-08_at_19.13.09 Screenshot_2024-09-08_at_18.35.51
Screenshot_2024-09-08_at_19.16.31 Screenshot_2024-09-08_at_18.35.30
Screenshot_2024-09-08_at_19.14.11 Screenshot_2024-09-08_at_18.36.06
Screenshot_2024-09-08_at_19.14.38 Screenshot_2024-09-08_at_18.36.32
Screenshot_2024-09-08_at_19.15.07 Screenshot_2024-09-08_at_18.37.07

Dark theme

Before After
Screenshot_2024-09-08_at_19.21.56 Screenshot_2024-09-08_at_18.37.27
Screenshot_2024-09-08_at_19.22.12 Screenshot_2024-09-08_at_18.37.41
Screenshot_2024-09-08_at_19.22.29 Screenshot_2024-09-08_at_18.37.52
Screenshot_2024-09-08_at_19.22.43 Screenshot_2024-09-08_at_18.38.18
Screenshot_2024-09-08_at_19.23.56 Screenshot_2024-09-08_at_18.38.30
Screenshot_2024-09-08_at_19.24.13 Screenshot_2024-09-08_at_19.01.46

How to set up and validate locally

  1. Make sure advanced search is installed and enabled
  2. Make sure you enable zoekt.
  3. Visit search page http://gdk.test:3000/search?group_id=33&scope=blobs&search=test&regex=true
  4. Search code using namespace where zoekt is enabled
  5. Check results while changing the code theme as well as system theme

Related to #481985 (closed)

Edited by Tomas Bulva

Merge request reports