Skip to content

Remove notes.scss

Annabel Dunstone Gray requested to merge remove-notes-css into master

What does this MR do and why?

  • Moves all styles out of notes.scss and deletes file
    • Code has been moved to relevant files (timeline.scss, system_notes.scss, notes_base.scss)
  • Fixes alignment of dot on system notes within MR diff threads (on Changes tab)

What does this MR not do?

It removes a few unneeded lines, but for the most part its a direct move from one file to another. I will be following up refactoring the code in each new file

Screenshots or screen recordings

  • The UI should remain unchanged, with the exception of this dot alignment (system note within a diff thread on an MR Changes tab):
Before After
Screenshot_2024-09-10_at_1.59.35_PM Screenshot_2024-09-10_at_1.59.52_PM

How to set up and validate locally

Check areas where notes are used

  • Issuables (issues, MRs)
  • Work items (tasks, epics)
  • Legacy items (commits, snippets)
  • User activity (system notes on profile page)

Links

Edited by Annabel Dunstone Gray

Merge request reports

Loading