Skip to content

Remove btn-block styling from GitLab button.scss

James Rushford requested to merge gitlab-community/gitlab:362857-migrate-btn-block-class-buttons-to-gl-button-block into master

What does this MR do and why?

Removes btn-block styling in GitLab in favour of GitLab-ui styling.

Style being removed Where will this style coming from if it is removed? 
width: 100%;

Exact same styling coming from:

node_modules/bootstrap/scss/_buttons.scss#L127

 
margin: 0;

Exact same styling coming from:

node_modules/bootstrap/scss/_reboot.scss#L324

 
&.btn {
    padding: 6px 0;
  }

Styling replaced by:

  @include gl-py-3;
  @include gl-px-4;

from:

src/components/base/button/button.scss#L78-79

Since btn-block is always 100% width, it is unlikely that it would ever make a difference in changing the horizontal padding from 0 to gl-px-4

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #362857 (closed)

Edited by James Rushford

Merge request reports