Skip to content

Follow-up from "Add missing handler for protected branches Deploy key"

Paulina Sedlak-Jakubowska requested to merge 456953-follow-up-from-add-missing-handler-for-protected-branches-deploy-key into master

What does this MR do and why?

  • add helper function for selecting a dropdown item in specs
  • call create() in a beforeEach whenever possible to limit the repetition
  • get rid of beforeEach where a block only has one it section
  • assert boolean for Bootstrap values, that cause console errors when running the spec

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
n/a n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Make sure spec/frontend/protected_branches/protected_branch_edit_spec.js passes.

Related to #456953 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports