Geo: make console messages consistent
What does this MR do?
This MR changes the method in which we use to notify customers at the console to use the standard gl_console_messages
approach.
Current
$ git push
> GitLab: You're pushing to a Geo secondary.
> GitLab: We'll help you by proxying this request to the primary: ssh://ash@localhost:2222/root/test.git
$ git push -u
> GitLab: You're pushing to a Geo secondary.
> GitLab: We'll help you by proxying this request to the primary: ssh://ash@localhost:2222/root/test.git
Total 0 (delta 0), reused 0 (delta 0)
remote:
remote: To create a merge request for new_branch, visit:
remote: https://ee-primary.local/root/test/merge_requests/new?merge_request%5Bsource_branch%5D=new_branch
remote:
To ssh://ee-secondary1.local:2222/root/test.git
vs.
New
$ git push -u
remote:
remote: You're pushing to a Geo secondary! We'll help you by proxying this
remote: request to the primary:
remote:
remote: ssh://ash@localhost:2222/root/test.git
remote:
Total 0 (delta 0), reused 0 (delta 0)
remote:
remote: To create a merge request for new_branch, visit:
remote: https://ee-primary.local/root/test/merge_requests/new?merge_request%5Bsource_branch%5D=new_branch
remote:
- gitlab-shell MR: gitlab-shell!334 (merged)
- Related: https://gitlab.com/gitlab-org/gitlab-ee/issues/14631
Does this MR meet the acceptance criteria?
Conformity
[ ] Changelog entry-
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides [ ] Database guides-
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono