Skip to content

Remove unnecessary association validation

Alex Buijs requested to merge remove-unnecessary-association-validation into master

What does this MR do and why?

Associated members do not need to be validated when updating a member role.

Doing so can cause request timeouts when many members are associated to the member role.

This was added to ensure the root namespace of associated members is equal to the root namespace of the member role (by calling the Member.validate_member_role_belongs_to_same_root_namespace validation).

Since we already have the MemberRole.validate_namespace_locked validation, which is run on update, we can be certain that once a member role is created, it's namespace is not changed anymore. This means that checking the validity of every associated member does not provide any added value and can be removed safely.

Issue: https://gitlab.com/gitlab-com/sec-sub-department/section-sec-request-for-help/-/issues/379

Edited by Alex Buijs

Merge request reports