Skip to content

Fixes issues with incorrectly displaying VR button

Darby Frey requested to merge fixes-incorrect-vr-button-rendering into master

What does this MR do and why?

This MR adds an additional check when displaying the resolve with AI button. The check will now differentiate between resolution being available and enabled. In the current context, available means a SAST type, and enabled means the vulnerability is on the high confidence list.

This resolves this bug: VR appearing for non-SAST vulnerabilities (#489875 - closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Dropdown

Tyes Outcome
Non-SAST image
SAST image
SAST (High confidence) image

Badge

Badge only appears for High confidence SAST

Types Outcome
SAST (high confidence) image
Non-SAST image

How to set up and validate locally

Vulnerability Report

  1. Clone this project (SAST): https://staging.gitlab.com/govern-team-test/oxeye-rulez
  2. Clone this project (non-SAST): https://gitlab.com/gitlab-examples/security/security-reports
  3. Go to the vulnerability report page > click on a vulnerability
  4. Non-SAST: Does not AI dropdown
  5. SAST (high confidence): Shows dropdown with VR enabled
  6. SAST: Shows dropdown with VR disabled

Badge

  1. Enable feature flag: vulnerability_report_vr_badge
  2. Clone this project: https://staging.gitlab.com/govern-team-test/oxeye-rulez
  3. Go to the vulnerability report page
  4. You will see the badge for VR enabled vulnerabilities
  5. If the "GitLab Duo features" is unchecked (docs), the badge will not appear for VR enabled vulnerabilities

Numbered steps to set up and validate the change are strongly suggested.

Relates: #489875 (closed)

Edited by Samantha Ming

Merge request reports

Loading