Skip to content

Allow reviewer unassign via quick action at MR creation

Jan Beckmann requested to merge gitlab-community/gitlab:kingjan1999/329978-assign-unassign-reviewer-same-time into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

This MR allows the /unassign_reviewer action to be used when creating merge requests. This can be useful when used in combination with merge request templates and "me" as a reviewer (see #329978 (closed)). !139712 (merged) already fixed this use case for notes in merge requests. Consequently, this MR now fixes it for MR descriptions on creation time by removing an apparently superfluous condition.

Screenshots or screen recordings

A MR created with this description:

mr description

triggers these quick actions:

mr activity new

Previously, both 'root' and 'richard' would be assigned:

mr activity old

How to set up and validate locally

  1. Create a MR request with this description:
/assign me 
/assign_reviewer [at]root [at]richard
/unassign_reviewer me

(adapt usernames as needed)

  1. Observe that only `richard is assigned as a reviewer
Edited by John Mason

Merge request reports