Skip to content

[BE] Clean-up the haml data injection left from earlier integration

Ammar Alakkad requested to merge 476521-clean-up-haml-data-injection into master

What does this MR do and why?

The MR cleans some haml data injection related to role promotion requests.

The frontend is fetching the data via GraphQL after the page loads, we don't need the HAML provided data.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes.

How to set up and validate locally

  1. Have an Ultimate License, and simulate Ultimate Self Managed setup (export GITLAB_SIMULATE_SAAS=0 gdk restart)
  2. Enable the Setting ApplicationSetting.first.update!(enable_member_promotion_management: true)
  3. Enable feature flag Feature.enable(:member_promotion_management)
  4. Create promotion requests:
    1. visit a group as an owner (e.g. http://gdk.test:3000/groups/gitlab-org/-/group_members)
    2. promote a non-billable GUEST member to a DEVELOPER role (this member should be non-billable on the whole instance, i.e. have a highest role as guest, see !149094 (comment 1869616221) for details)
    3. you should see a banner saying "Role change request was sent to the administrator." — this means a promotion request has been created
  5. navigate to the group's members page, you should see "Promotion Requests" tab, ensure it's showing the members properly.

Related to #476521 (closed)

Edited by Ammar Alakkad

Merge request reports