Fix deduplicate strategy in package cleanup limited capacity workers
requested to merge 490497-fix-deduplicate-strategy-in-package-cleanup-limited-capacity-workers into master
Context
The following background workers currently have their deduplication strategy set as until_executed
:
Packages::Npm::CleanupStaleMetadataCacheWorker
Packages::Nuget::CleanupStaleSymbolsWorker
Since they're all limited capacity workers, they shouldn't override the default deduplicate :none
.
What does this MR do and why?
- Remove the overriding
deduplicate
declaration fromPackages::Npm::CleanupStaleMetadataCacheWorker
&Packages::Nuget::CleanupStaleSymbolsWorker
. - Add covering specs.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
In rails console:
Packages::Nuget::CleanupStaleSymbolsWorker.get_deduplicate_strategy
=> :none
# on master
Packages::Nuget::CleanupStaleSymbolsWorker.get_deduplicate_strategy
=> :until_executed
Related to #490497 (closed)
Edited by Moaz Khalifa