Skip to content

Fix errors when placeholder username path taken

Luke Duncalfe requested to merge 467512-placeholder-user-creator-check-path into master

What does this MR do and why?

In this import test #467512 (comment 2125354838) we noticed errors:

Validation failed: A user, alias, or group already exists with that
username.

The username errors come from here and will be because when creating placeholder users we were previously checking only if the username existed, but in UsernameAndEmailGenerator the check is ::Namespace.by_path(suggested_username).

This updates PlaceholderUserCreator to use the same logic.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #467512 (closed)

Merge request reports