Skip to content

Minimize !important use in zen-control-leave style

Chad Lavimoniere requested to merge 20240911-clavimoniere-markdown-fullscreen-exit-2 into master

What does this MR do and why?

A few of the applied styles for zen-control-leave do not need to be important-decorated.

Screenshots or screen recordings

Note: There is no visual change introduced in this MR.

Version Before After
Vue gdk.test_3000_flightjs_Flight_-issues_92__5 gdk.test_3000_flightjs_Flight_-issues_92__4
Haml gdk.test_3000_flightjs_Flight_-commit_36b52e45cb018a8cae840cd19aa4f123ea16ddd7__1 gdk.test_3000_flightjs_Flight_-_commit_36b52e45cb018a8cae840cd19aa4f123ea16ddd7

How to set up and validate locally

Testing this MR is essentially confirming that both zen mode leave controls (the one in Vue and the one in Haml) continue to behave identically to prod with this change in css.

  1. Visit an issue or MR on the GDK
  2. In the new comment field, ensure you're using markdown
  3. click the "Go full screen" button
  4. You should see that the "Exit full screen" button in the top right corner is styled identically to the current tip of master (i.e., gitlab as of commit 56d8d2cc)
  5. Visit a commit in the GDK
  6. In the comment field, click the fullscreen button
  7. You should see that the "Exit full screen" button in the top right corner is styled identically to the current tip of master (i.e., gitlab as of commit 56d8d2cc)

Related to #474921 (closed)

Merge request reports