Skip to content

Use consts for list_selector types

What does this MR do and why?

Changing the strings passed to specify a type prop on ListSelector to previously defined constants.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-09-27_at_11.33.40 Screenshot_2024-09-27_at_11.26.05
Screenshot_2024-09-27_at_11.33.08 Screenshot_2024-09-27_at_11.25.51
Screenshot_2024-09-27_at_11.35.24 Screenshot_2024-09-27_at_11.24.16
Screenshot_2024-09-27_at_11.35.16 Screenshot_2024-09-27_at_11.24.01

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to /admin/application_settings/integrations/beyond_identity/overrides. Click Add exclusions
  2. Make sure you can select existing groups and projects.
  3. Go to a chosen project. Navigate to Settings / Merge Requests and scroll down to MR approvals.
  4. Click Add approval rule and make sure you can select groups and users.

Related to #478027 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports

Loading