Skip to content

Reapply "Include axe checks in todos feature test"

Paulina Sedlak-Jakubowska requested to merge psj-todos-accessibility-tests into master

What does this MR do and why?

  • reinstates accessibility tests and improvements from reverted !161036 (merged)
  • adds wait_for_requests to ensure we get consistent test results (the tests were flaky, here are the outputs for when they failed on master: #493156 (closed) )
  • fixes wrongly placed aria-label attributes for todo item control
  • fixes contrast issue on a reversible todo, while keeping it grey-scale to make it stand out

Reapply "Merge branch..."

This reverts commit b37e8373.

Solves:

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
todos_redo_before todos_redo_after
Screen_Recording_2024-09-27_at_16.37.07 todos_after_changes

How to set up and validate locally

  1. Turn on a screen reader of your choice (easiest on MacOS is Settings / Accessibility / VoiceOver)
  2. Navigate to To-Dos dashboard
  3. Tab through the list, click "Mark as done" and then "Undo". You should here those announced by a screen reader.

Numbered steps to set up and validate the change are strongly suggested.

Edited by Paulina Sedlak-Jakubowska

Merge request reports