Skip to content

Fix value stream analytics default date

Felipe Cardozo requested to merge issue_338332_fix_date_timezone into master

What does this MR do and why?

Value stream analytics was using wrong dates when filtering data, this happens because javascript considers a date string like 2024-09-27 as 2024-09-27:00:00:00 then, in my localhost for example, this gets converted to 2025-08-26:00:00:00 GMT -3 which is one day before the original parameter.

This situation makes spec/features/cycle_analytics_spec.rb:165 always fail in localhost browsers with timezone < UTC 0 because it renders data from one day before the expected, but passes on CI which has default UTC 0 timezone.

related to #338332 (closed)

How to set up and validate locally

  1. run (spec/features/cycle_analytics_spec.rb:165)[https://gitlab.com/gitlab-org/gitlab/-/blob/6646d2a5e44a248ad5454b480dee8d1da7c221d7/spec/features/cycle_analytics_spec.rb#L165] on master and it will fail
  2. Change to this branch and the same spec should pass
Edited by Felipe Cardozo

Merge request reports

Loading