Skip to content

Remove gl-avatar style overrides

Scott de Jonge requested to merge sdejonge-remove-avatar-dark-mode-overrides into master

What does this MR do and why?

Remove gl-avatar style overrides and SCSS variables, rely on GlAvatar as a the source-of-truth for dark mode rendering.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
gdk.test_3443_admin_credentials__1_ gdk.test_3443_admin_credentials
gdk.test_3443__root__1_ gdk.test_3443__root
gdk.test_3443_flightjs_Flight_-merge_requests_4__3 gdk.test_3443_flightjs_Flight_-merge_requests_4__2

How to set up and validate locally

  1. Update profile preferences to use dark mode https://gdk.test:3443/-/profile/preferences
  2. Review avatar usage in dark mode
    1. .avatar styles in https://gdk.test:3443/admin/credentials
    2. .gl-avatar styles in https://gdk.test:3443//root, https://gdk.test:3443/flightjs/Flight/-/merge_requests/4 etc.
Edited by Scott de Jonge

Merge request reports