Skip to content

Flash alerts: Fix sticky position

Sascha Eggenberger requested to merge alerts-fix-sticky-flash-alerts into master

What does this MR do and why?

Flash alerts: Fixes sticky position not applying on pages for GlAlert's

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before2 after2

How to set up and validate locally

  1. Apply patch
  2. Go to http://gdk.test:3000/admin/groups
  3. Edit a group
  4. Edit field Group URL
  5. Check if error message is appearing (positon sticky)
Patch:
diff --git a/app/assets/javascripts/groups/components/group_name_and_path.vue b/app/assets/javascripts/groups/components/group_name_and_path.vue
index 06eaaa4eb50c..144171ad44db 100644
--- a/app/assets/javascripts/groups/components/group_name_and_path.vue
+++ b/app/assets/javascripts/groups/components/group_name_and_path.vue
@@ -192,7 +192,7 @@ export default {
 
         this.apiLoading = false;
 
-        if (exists) {
+        if (true) {
           if (suggests.length) {
             return Promise.resolve({ exists, suggests });
           }
diff --git a/app/views/layouts/header/_openssl_callout.html.haml b/app/views/layouts/header/_openssl_callout.html.haml
index f51daf2c3ae0..a89595c1ce04 100644
--- a/app/views/layouts/header/_openssl_callout.html.haml
+++ b/app/views/layouts/header/_openssl_callout.html.haml
@@ -1,4 +1,4 @@
-- return unless show_openssl_callout?
+-# - return unless show_openssl_callout?
 
 -# rubocop:disable Gitlab/DocUrl -- This documentation section is only available in version 17.4 onward in GitLab.com.
 - link = link_to('', 'https://docs.gitlab.com/ee/update/versions/gitlab_17_changes.html#1770', target: '_blank', rel: 'noopener noreferrer')
diff --git a/app/views/shared/_outdated_browser.html.haml b/app/views/shared/_outdated_browser.html.haml
index d26f377272b3..fa9caac7dd6c 100644
--- a/app/views/shared/_outdated_browser.html.haml
+++ b/app/views/shared/_outdated_browser.html.haml
@@ -1,4 +1,4 @@
-- if outdated_browser?
+- if not outdated_browser?
   = render Pajamas::AlertComponent.new(variant: :danger, dismissible: false) do |c|
     - c.with_body do
       = s_('OutdatedBrowser|GitLab may not work properly, because you are using an outdated web browser.')
diff --git a/app/views/shared/projects/_inactive_project_deletion_alert.html.haml b/app/views/shared/projects/_inactive_project_deletion_alert.html.haml
index 6c209ce1d792..15cd03cc26bc 100644
--- a/app/views/shared/projects/_inactive_project_deletion_alert.html.haml
+++ b/app/views/shared/projects/_inactive_project_deletion_alert.html.haml
@@ -1,7 +1,7 @@
-- if show_inactive_project_deletion_banner?(@project)
+- if not show_inactive_project_deletion_banner?(@project)
   - link_start = '<a href="%{url}" target="_blank" rel="noopener noreferrer">'.html_safe % { url: help_page_path('administration/inactive_project_deletion.md') }
   - link_end = '</a>'.html_safe
-  - deletion_date = inactive_project_deletion_date(@project)
+  - deletion_date = '2024-12-12'
   - title = _('Due to inactivity, this project is scheduled to be deleted on %{deletion_date}. %{link_start}Why is this scheduled?%{link_end}').html_safe % { deletion_date: deletion_date, link_start: link_start, link_end: link_end }
 
   = render Pajamas::AlertComponent.new(title: title, variant: :warning, dismissible: false)

Closes #497088 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading