Skip to content

Remove error message from gitlab:geo:check rake task if replication not enabled

Scott Murray requested to merge 491296-update-geo-check-rake-task into master

What does this MR do and why?

This MR makes the following changes -

  • Adds a new feature flag - geo_postgresql_replication_agnostic relating to this epic - &13721
  • When the geo_postgresql_replication_agnostic feature flag is enabled:-
    • The error message from DatabaseReplicationEnabledCheck, (triggered via the rake task gitlab:geo:check), will not be displayed if replication is not enabled
    • The DatabaseReplicationWorkingCheck from the same rake task will be skipped, if replication is not enabled

Relates to #491296 (closed)

Changelog: changed EE: true

How to set up and validate locally

  1. Set up a secondary Geo site
  2. Ensure replication is disabled
  3. Enable the new feature in the rails console with Feature.enable(:geo_postgresql_replication_agnostic)
  4. Run bundle exec rails gitlab:geo:check from the secondary
  5. Observe the output - error message should no longer be present, and the DatabaseReplicationWorkingCheck should be skipped with the message replication is disabled

Related to #491296 (closed)

Edited by Scott Murray

Merge request reports

Loading