Skip to content

User mapping FE - Refetch sourceUsers list when user is reassigned

What does this MR do and why?

A 'bug' in our unshipped user contribution mapping feature was found in which after a reassignment is made and the user attempts to sort, the sort is not applied.

My reproduction of the issue was as follows (in the Before video):

  • Start with the sort on status-ascending
  • Reassign a user
  • Click on the sort direction (change to DESC)
  • Reassign a different user
  • Change the sort direction

For the second manual sort, no graphql request was being made and the table results appear unsorted (or badly sorted). In addition, when you reassign, the item with the changed status is not immediately sorted.

This MR makes sure that the query that populates the source users table runs more consistently.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
2ndAttemptAtBaseState Screen Recording 2024-10-08 at 5.31.48 PM.mov

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Navigate to http://127.0.0.1:3000/groups/flightjs/-/group_members?tab=placeholders
  2. Select a user to reassign (search in the dropdown under 'Reassign placeholder to')
  3. After the assignment is done, the table should sort
  4. Change the sort direction
  5. Select another user to reassign (preferably mid way down the table)
  6. The table should sort correctly
  7. Change the sort direction again.

Related to #495794 (closed)

Edited by Oiza Baiye

Merge request reports

Loading