Skip to content

Require Source in Members::UpdateService Again

Jason Goodman requested to merge require-source-in-members-update-service-again into master

What does this MR do and why?

Require source in Members::UpdateService.

In every use of the service, members are already scoped to a single source. Requiring the source encodes this into the service. The source can also be used directly rather than obtained from one of the passed in members.

This MR is spun out from this conversation: !167358 (comment 2136769925)

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/472299

This is attempt number 2 after !167828 (merged) had to be reverted: !168030 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jason Goodman

Merge request reports