Badges - Migrate to Server Side Pagination
What does this MR do and why?
Closes #29704 (closed)
This change fixes a long standing bug where the Group and Project badges list are client side paginated but the API handles the pagination server side. This causes a bug where no more than 20 badges can ever be seen on the client.
The fix is to properly manage the pagination server side from the client.
Important
Vuex is depreciated at GitLab. However, as this is a bug fix the main intention is to get the feature into working order and a migration to Apollo can be scheduled down the road.
Screenshots or screen recordings
Before | After | |
---|---|---|
Projects | Projects_-_Before | Projects_-_After |
Groups | Groups_-_Before | Groups_-_After |
How to set up and validate locally
- Go to Group or Project
- In the left bar go to Settings > General
- Scroll to the Badges section and expand it
- Add more than 20 badges
- Ensure pagination works as expected
- Ensure you can add/edit/delete badges as expected
Related to #29704 (closed)
Edited by Zack Cuddy