Add db_config_database into marginalia comments
What does this MR do and why?
Add db_config_database into marginalia comments
This commit adds db_config_database
into the marginalia comments to
indicate the database used by the connection for an SQL query.
This change affects users connecting to the database through a
pgbouncer. The db_config_database
in the marginalia comment will map
to the pgbouncer connection pool name. This way, different pg backends
connected through separate pgbouncer pools on the same pgbouncer instance
can be distinguished.
Knowing the pgbouncer connection pool used lets us determine the endpoints responsible for saturating different pgbouncer connection pools.
This change does not affect users connecting directly to the database.
Changelog: other
See gitlab-com/gl-infra/scalability#3857 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.