Skip to content

Migrate "quarantined-deprecated-btn" to be Pajamas Compliant in app/assets/javascripts/work_items/components/design_management/design_preview/close_button.vue

Alexander Ikonomou requested to merge gitlab-community/gitlab:497379-migrate-close_button.vue-to-gl-button into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

This makes the close button in the design preview of the design management Pajamas Compliant. Before, it used the class quarantined-deprecated-btn. Now, it uses the gl-button component.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit a work item with the endpoint work_items/:idd. On the GDK for Gitpod, this works flightjs/Flight/-/work_items/1.
  2. Click on add design and upload a design.
  3. Click on the uploaded design.
  4. On the top right is the close button.

If you do not have a work item, you can create a new one with work_items/new and follow the steps accordingly.

More information can be found on the Work items development page.

Related to #497379
See also &15411

Edited by Alexander Ikonomou

Merge request reports