Fix for #24832, naming a project "shared" will not open the "Shared Projects" tab
What does this MR do?
This is a fix for #24832 (closed), formerly gitlab-foss issue #53041 .
For groups named "shared" or "archived", when opening the group, the UI will immediately jump to the "Shared Projects" or "Archived Projects" tabs.
This MR fixes this, users will now remain in the "Subgroups and Projects" tab as expected.
Details
This is simply a case where the path segment being used to identify the tab location is looking after the first "/", which happens to be the group name. Changing the locator to "/-/" ensures it looks at the proper path segment.
I did not see a good place anywhere in the tests to test for this behavior. I am submitting this as a WIP until I can get feedback on where to add an appropriate test.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
What risks does this change pose? How might it affect the quality/performance of the product?
As mentioned above, I did not see anywhere where the movement between group tabs is tested (as controlled by the javascript). I am keeping this as a WIP until I can get feedback on where to add an appropriate test.
There appear to be many more
What additional test coverage or changes to tests will be needed?
See comments above.
Will it require cross-browser testing?
No
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process
Closes #24832 (closed)