Check for software license compliance violations after license management report is generated.
What does this MR do?
This fixes a defect identified here. In this defect, we resolve the approval rules before the license management report is generated. This change waits for a license management report to be produced before checking for software license compliance violations. This ensures that when an MR is first submitted, the approval rule will default to requiring an approval until a valid license report is generated.
Screenshots
Before:
After:
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by mo khan