Skip to content

Ensure all ApplicationSetting attributes have a definition file and vice-versa

What does this MR do and why?

  • Introduce scripts/cells/ci-ensure-application-settings-have-definition-file.rb to check that
    • Each ApplicationSetting attributes have a corresponding config/application_setting_columns/*.yml file
    • Each config/application_setting_columns/*.yml file actually relate to an existing ApplicationSetting attribute
  • Introduce a new ensure-application-settings-have-definition-file job that runs the above script when db/structure.sql or config/application_setting_columns/*.yml files are touched

The job is currently passing: https://gitlab.com/gitlab-org/gitlab/-/jobs/8024846988 🚀

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #496758 (closed).

Edited by David Dieulivol

Merge request reports

Loading