Lazy render emoji dropdown
What does this MR do and why?
fix #498419 (closed) - performance issue and lots of network requests for custom emojis.
Removes potentially lots of DOM nodes, and prevents lots of duplicate network requests.
How to test
-
Add some custom emojis
mutation CreateCustomEmoji($groupPath: ID!) { createCustomEmoji(input: {groupPath: $groupPath, name: "party-parrot", url: "https://cultofthepartyparrot.com/parrots/hd/parrot.gif"}) { clientMutationId customEmoji { name } errors } }
- Load an issue with some comments on it
- Check network responses - should be fewer than without this change
- Check DOM (in Elements tab, search for "Search for an emoji" with cmd+f searchbar) - there should only be a picker when it has been opened
Edited by Simon Knox