Skip to content

Split elastic/project_search_spec.rb feature specs in three separate files

David Dieulivol requested to merge ddieulivol-split_project_search_spec into master

From Draft to Ready

  • CI is green
  • We have performance data in this issue description

Context

Contributes to #497336 (closed).

What does this MR do and why?

Splits the ee/spec/features/search/elastic/project_search_spec.rb into three separate files.

The file already contains two separate RSpec.describe top-level blocks (which is misleading, as our automations expect one of those top-level blocks). The first RSpec.describe block takes around 6 minutes (example), and the second one takes 19 minutes (example).

I'm proposing to split the second block into two separate files, as it's already nicely compartimentalized.

CI Performance

  • ee/spec/features/search/elastic/project_search_redactions_issue_spec.rb ran in CI, and it took 10 minutes 20.92 seconds 🎉
  • ee/spec/features/search/elastic/project_search_redactions_work_item_spec.rb ran in CI, and took a bit less than 10 minutes 🎉
  • ee/spec/features/search/elastic/project_search_spec.rb ran in CI, and took 5 minutes 🎉

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by David Dieulivol

Merge request reports